Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add a typeos check in CI, and fix current existly typos errors. that is a TODO thing, and it's done now. #1340

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

xyq-c-cpp
Copy link

@xyq-c-cpp xyq-c-cpp commented Jun 14, 2024

Description

enhancement: add a typeos check in CI, and fix current existly typos errors. that is a TODO thing, and it's done now.

Issue Link

#1219

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

@lispc please review this.

How Has This Been Tested?

Single responsability

fix current existly typos and add a typos check in CI

Design choices

enhancement

@lispc
Copy link

lispc commented Jun 14, 2024

great job!

@lispc lispc merged commit 2f178fa into scroll-tech:develop Jun 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants